Skip to content

Fix orientation of cubemap sample, add clearer attribution #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 29, 2024
Merged

Fix orientation of cubemap sample, add clearer attribution #419

merged 1 commit into from
May 29, 2024

Conversation

@kainino0x
Copy link
Collaborator

Fixes #341

@kainino0x kainino0x requested a review from greggman May 25, 2024 04:14
greggman
greggman approved these changes May 26, 2024
View reviewed changes
Copy link
Collaborator

@greggman greggman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kainino0x kainino0x merged commit bf7948f into webgpu:main May 29, 2024
@kainino0x kainino0x deleted the cube-flip branch May 29, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@greggman greggman greggman approved these changes

Assignees

No one assigned

Labels

issue about one sample

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Is the cubemap example correct? (Flipped church)

2 participants

@kainino0x @greggman